Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds codecov; closes #230 #231

Merged
merged 5 commits into from
Dec 11, 2017
Merged

adds codecov; closes #230 #231

merged 5 commits into from
Dec 11, 2017

Conversation

cglewis
Copy link
Contributor

@cglewis cglewis commented Oct 30, 2017 •
edited
Loading

Fixes #230

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • N/A I have added necessary documentation about the functionality in the appropriate .md file
  • N/A I have added in line documentation to the code I modified

Short description of what this PR does:

  • adds codecov to testing with travis

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 30, 2017
@SendGridDX
Copy link

SendGridDX commented Oct 30, 2017 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Oct 31, 2017 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@ece97af). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #231   +/-   ##
=========================================
  Coverage          ?   70.94%           
=========================================
  Files             ?        3           
  Lines             ?      413           
  Branches          ?        0           
=========================================
  Hits              ?      293           
  Misses            ?      118           
  Partials          ?        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ece97af...439248c. Read the comment docs.

@cglewis
Copy link
Contributor Author

cglewis commented Nov 1, 2017

the check that failed is because there was no report found to compare against, but since this is the first one, it's not actually an issue.

@mbernier mbernier merged commit 441c3bf into sendgrid:master Dec 11, 2017
@thinkingserious
Copy link
Contributor

Hello @cglewis,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

@mbernier
Copy link
Contributor

@cglewis

If you are interested, we would love the opportunity to talk to you about Hacktoberfest and our API libraries.

Our agenda would be: Explore what you liked and is there anything we can do to improve?

You can grab a time on my calendar that works for you and we can have a chat on Google Hangout or Skype. If you prefer, you can email me using my GitHub username at my company’s domain.

Thank you so much,

Matt Bernier - @mbernier - SendGrid Developer Experience Product Manager
Elmer Thomas - @thinkingserious - SendGrid Developer Experience Engineer
@sendgrid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status: code review request requesting a community code review or review from Twilio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add CodeCov support to .travis.yml
4 participants
@cglewis @SendGridDX @thinkingserious @mbernier