Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Gometalinter in Travis CI build #228

Merged
merged 3 commits into from
Nov 1, 2017

Conversation

vaskoz
Copy link
Contributor

@vaskoz vaskoz commented Oct 29, 2017

Fixes #227

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • Added the gometalinter to the TravisCI build
  • Enabled the following linters errcheck,vet,vetshadow,megacheck for starters.
  • Invoked gometalinter twice in the following paths: . and helpers/... to avoid numerous warnings in the examples folder.
  • Fixed a few small issues found by the enabled linters.
gometalinter --disable-all --enable=errcheck --enable=vet --enable=vetshadow --enable=megacheck helpers/...
helpers/inbound/inbound.go:70::warning: declaration of "err" shadows declaration at helpers/inbound/inbound.go:67 (vetshadow)
helpers/inbound/inbound.go:165::warning: declaration of "value" shadows declaration at helpers/inbound/inbound.go:149 (vetshadow)
helpers/inbound/inbound.go:169::warning: declaration of "header" shadows declaration at helpers/inbound/inbound.go:153 (vetshadow)
helpers/inbound/inbound.go:211:22:warning: error return value not checked (http.ListenAndServe(port, nil)) (errcheck)

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 29, 2017
@thinkingserious thinkingserious added difficulty: easy fix is easy in difficulty hacktoberfest labels Oct 29, 2017
@mbernier mbernier added difficulty: medium fix is medium in difficulty and removed difficulty: easy fix is easy in difficulty labels Nov 1, 2017
@mbernier mbernier merged commit 64f7d73 into sendgrid:master Nov 1, 2017
@thinkingserious
Copy link
Contributor

Hello @vaskoz,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: medium fix is medium in difficulty status: code review request requesting a community code review or review from Twilio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add megacheck to TravisCI checks
3 participants