Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong mail helpers example directory in README #198

Merged
merged 2 commits into from
Oct 24, 2017

Conversation

tkbky
Copy link
Contributor

@tkbky tkbky commented Oct 23, 2017

What

The example directory for mail helpers is incorrect in helpers/mail/README.md. This fixes that.

Why

It might confuse the user with examples/mail/mail.go

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 23, 2017
@SendGridDX
Copy link

SendGridDX commented Oct 23, 2017

CLA assistant check
All committers have signed the CLA.

@@ -9,7 +9,7 @@
Run the [example](https://github.com/sendgrid/sendgrid-go/tree/master/examples/mail) (make sure you have set your environment variable to include your SENDGRID_API_KEY).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please modify this link to match the helper link below?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, miss that. 😬

@mbernier mbernier added difficulty: easy fix is easy in difficulty hacktoberfest labels Oct 24, 2017
@mbernier
Copy link
Contributor

NBD. Thanks for making the change!

@mbernier mbernier merged commit 003a205 into sendgrid:master Oct 24, 2017
@thinkingserious
Copy link
Contributor

Hello @tkbky,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants