Fix error in default multi-reports when rendering uncertainties #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed the analysis result from the function call, because this was removed in: senaite/senaite.core#2224
…ti-reports-format-uncertainty
xispa
approved these changes
Feb 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses
This PR fixes the following error when rendering one of the default multi-reports with uncertainties:
Current behavior before PR
The function
format_uncertaintieswas called with the analysis result as parameter, which was removed in senaite/senaite.core#2224.This caused a rendering error and the reports were not displayed
Desired behavior after PR is merged
Multi reports render correctly
--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.