Only one results report is generated when SingleReport template is selected #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramonski
reviewed
May 20, 2022
Comment on lines
+284
to
+287
| base_path, uids = url.split("?uids=") | ||
| path_uids = groups.get(base_path, "") | ||
| groups[base_path] = ",".join(filter(None, [path_uids, uids])) | ||
| return "?uids=".join(groups.items()[0]) |
There was a problem hiding this comment.
Careful about this one. AFAIK the UIDs might also come in as a POST request inside the payload. Better use urlparse for this task (https://six.readthedocs.io/index.html?highlight=urlparse#module-six.moves)
There was a problem hiding this comment.
The urls from exit_urls are always generated by the get_exit_url_for function here
senaite.impress/src/senaite/impress/ajax.py
Lines 272 to 273 in 7448015
And get_exit_url_for always returns a GET with uids parameter and the action passed-in as the endpoint:
senaite.impress/src/senaite/impress/ajax.py
Lines 324 to 326 in 7448015
ramonski
approved these changes
May 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses
This Pull Request fixes a bug introduced with #119 that causes the system to only render (and publish) the report for the first selected sample when a "SingleReport"-like template is used.
Current behavior before PR
System only renders/publishes/emails the first sample when a "SingleReport"-like template is used
Desired behavior after PR is merged
System renders/publishes/emails all samples when a "SingleReport"-like template is used
--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.