Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2 Factor Authentication #683

Open
brimdor opened this issue Jul 24, 2021 · 19 comments
Open

2 Factor Authentication #683

brimdor opened this issue Jul 24, 2021 · 19 comments

Comments

@brimdor
Copy link

brimdor commented Jul 24, 2021

It currently uses basic auth with its own user management. What about incorporating 2 factor authentication? Building out users and allowing access via their enterprise authentication?

@fiftin
Copy link
Collaborator

fiftin commented Aug 11, 2021

Hi @brimdor, may be LDAP can help?

@brimdor
Copy link
Author

brimdor commented Aug 20, 2021

I'm sure LDAP works fine in general, however, I use SAML SSO in my environment that I'm trying to implement this.

@nlvw
Copy link

nlvw commented Sep 27, 2021

SAML or OIDC (OpenID Connect) would be amazing. Really convenient as the SSO provided will handle 2FA instead of have to code that into this App.

@KenK73
Copy link

KenK73 commented Oct 15, 2021

Or... since this project recommends nginx for SSL support anyway, why not support passing user creds from nginx? I am running an nginx proxy as a docker container in front of the semaphore container. I have nginx prompting for username/pass and on some of my other containers that support web auth it just passes that through (phpIPAM and mediawiki for example). Currently the nginx does the authentication against my LDAPS servers, and when the time comes to get that working with smartcard, I only have to reconfigure nginx.

@hmoffatt
Copy link
Contributor

@KenK73 indeed just trusting the remote user name in REMOTE_USER would be good. I use Apache with mod_auth_openidc to handle authentication with OpenID Connect here.

@fiftin
Copy link
Collaborator

fiftin commented Jan 14, 2022

Hi @KenK73, @hmoffatt How it can be implemented?

@hmoffatt
Copy link
Contributor

hmoffatt commented Jan 14, 2022

Apache will handle the authentication and provide the username in an HTTP header.

The admin will need to configure Apache to pass the username in a header. See https://renaudmarti.net/posts/make-apache-proxy-remote-user-to-backend/ for example.

Then the app would skip the login page and use the username from the header.

@Weilbyte
Copy link

Weilbyte commented Jul 5, 2022

@fiftin I could give it a try at implementing 2FA (TOTP) for non-LDAP users.

@KenK73
Copy link

KenK73 commented Jul 5, 2022 via email

@Weilbyte
Copy link

Weilbyte commented Jul 6, 2022

@KenK73 what SAML provider do you use?

@KenK73
Copy link

KenK73 commented Jul 6, 2022

Are you asking about the IDP? Ping Federate is what we've started rolling out. Maybe I dont understand what you are asking. I am not well versed in SAML just yet, I just see it working pretty well on our other apps that support it.

@ff-fgomez
Copy link

+1 on the SSO implementation. It's a lot cleaner and secure than LDAP. Please and thank you!

@hmoffatt
Copy link
Contributor

OpenID Connect would be good too (preferable to SAML).

@jonahbohlmann
Copy link

+1 would be really good

@xrpixer
Copy link

xrpixer commented Jun 16, 2023

+1 would be really really good

@Alex-Giaquinto
Copy link

+1 on the SSO implementation. Even being able to authenticate users with Github would be incredible. (Similar to how AWX does it)

@wakawakaaa
Copy link

2FA is needed

@hmoffatt
Copy link
Contributor

hmoffatt commented Mar 2, 2024

Use OpenID Connect and let your IDP do 2FA.

@tboerger
Copy link
Collaborator

tboerger commented Mar 2, 2024

IMHO this issue can get closed. It is possible to enable 2FA on an OIDC/OAuth2 provider. There are much more important features or fixes than building your own 2FA mechanism for local or LDAP users.

@fiftin fiftin self-assigned this Dec 19, 2024
@fiftin fiftin modified the milestones: v3.0, 2.12 Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests