-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixups: post-merge updates related to PR #6241 #6335
Fixups: post-merge updates related to PR #6241 #6335
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
QUnit.test
instead of relying on global namespace entry
@kevin-brown something about the |
The problem seems to be that
I attempted to add a The second approach doesn't appear straightforward either; there is no ...so I've slightly-reluctantly implemented the third approach. It doesn't genuinely provide any meaningful runtime isolation between the integration test cases, but it ensure that each event listener should only perform any actions within the scope of its parent test case. |
@kevin-brown it's not ideal code (details in my previous message if you're curious), but I believe this is ready for merge. |
I'll take the "temporary" hack for now. Thanks for looking into this and documenting your findings! |
This pull request includes a
The following changes were made
test
in an integration test added by Fixup: unselection of items from AJAX data sources with non-string identifiers #6241, use the fully-qualified referenceQUnit.test
instead, as becomes standard after Dependencies/CI: updates to prepare for jQuery 4.0.0-beta testing #6334.selection:update
event handlers in the integration tests, because these are not isolated from each other at test runtime, and otherwise may delay/timeout unrelated test cases.If this is related to an existing ticket, include a link to it as well.
Relates-to / merge-resolution-for #6241 and #6334.
Edit: add additional fixup descriptions.