build: add golangci-lint to circleci config #907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominicbarnes
force-pushed
the
golangci-lint
branch
10 times, most recently
from
6574b2a to
7f45429
Compare
achille-roussel
approved these changes
May 13, 2022
dominicbarnes
force-pushed
the
golangci-lint
branch
from
9e09c98 to
e02eb7b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds golangci-lint to our CircleCI configuration. The main intent is to fix #877 but it appears like many other subtle bugs could be uncovered with this extensive of a linting tool.
Once the initial run happens, we'll have a sense for how many errors there are to fix.