chore(examples): update kafka-go #649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, simply running `docker-compose up` in `examples/` doesn't work 100% correctly. When starting up docker-compose containers, it doesn't expose any mechanism to wait on a particular host to respond in a particular way, and kafka has a tendency to boot up pretty slowly. In the producer-random example, it produces a message every second. One would expect that even if kafka isn't reachable right away, it would eventually succeed once kafka fully boots up. Unfortunately, the older version of kafka-go seems to hold on to the initial error, never able to succeed after failing to start. By updating kafka-go, this seems to clear up all the problems reported in #637, and thus should fix that issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, simply running
docker-compose upinexamples/doesn't work 100% correctly. When starting up docker-compose containers, it doesn't expose any mechanism to wait on a particular host to respond in a particular way, and kafka has a tendency to boot up pretty slowly.In the producer-random example, it produces a message every second. One would expect that even if kafka isn't reachable right away, it would eventually succeed once kafka fully boots up. Unfortunately, the older version of kafka-go seems to hold on to the initial error, never able to succeed after failing to start.
By updating kafka-go, this seems to clear up all the problems reported in #637, and thus should fix that issue. It turns out we had pretty old versions of kafka-go hanging around, so they've all been updated to the latest (v0.4.15).