Revisit sync commits #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
savaki
suggested changes
Jan 10, 2018
reader.go
Outdated
| } | ||
| } | ||
| } | ||
|
|
||
| func (r *Reader) commitOffsetStash(conn offsetCommitter) error { |
There was a problem hiding this comment.
given commitOffsetStash is only called from one place and it only performs a single task and is already wrapped in the commit func, is there a reason not to inline it above?
There was a problem hiding this comment.
Not really, I can change that 👍
|
Looks good to me. |
|
Thanks for the review 👍 |
achille-roussel
added a commit
that referenced
this pull request
Jan 10, 2018
* add CommitMessages documentation * Revisit sync commits (#59) * revisit sync commits * drop commit request chan capacity * remove error prone check * shorter code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@savaki I modified the
CommitMessagesimplementation in the case where the reader is configured to use synchronous commits, in which case the method now actually waits for the commit to complete and any error is propagated back to the program.