Update Error consts and Error.Temporary()
#372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thanks for the contribution!
Could you explain how you determined whether an error was temporary or not? Looking at the documentation link you added I assumed it would be based on whether the error is marked as "Retriable", but it seems like some are missing then? (e.g. CORRUPT_MESSAGE).
|
@achille-roussel yes I just included the errors marked as "Retriable" in the documentation. For some reason |
|
Got it, thanks for clarifying. Kafka must have changed the name of the error between versions, this code was written when 0.10 was the latest version. |
|
thanks for the super-fast turnaround! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main goal is to update the list of
Temporaryerrors. My application dropped many messages when a Kafka broker was down due to aNotEnoughReplicaserror, so I thought it would be good to update them all.https://kafka.apache.org/protocol#protocol_error_codes specifies which errors are retriable.