Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added clarifying docs on Writer batching behavior #256

Merged
merged 1 commit into from
Apr 9, 2019
Merged

Added clarifying docs on Writer batching behavior #256

merged 1 commit into from
Apr 9, 2019

Conversation

stevevls
Copy link
Contributor

@stevevls stevevls commented Apr 9, 2019

Fixes #92

achille-roussel
achille-roussel approved these changes Apr 9, 2019
View reviewed changes
Copy link
Contributor

@achille-roussel achille-roussel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotta love the tests failing on this one 😜

@stevevls
Copy link
Contributor Author

stevevls commented Apr 9, 2019

Oh yeah...very confidence inspiring. 😉

@stevevls stevevls merged commit 1761ee8 into master Apr 9, 2019
@stevevls stevevls deleted the batch-size-doc-clarification branch April 9, 2019 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achille-roussel achille-roussel achille-roussel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stevevls @achille-roussel