Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workaround for racy testReaderStats test #214

Merged
merged 1 commit into from
Feb 21, 2019
Merged

Workaround for racy testReaderStats test #214

merged 1 commit into from
Feb 21, 2019

Conversation

stevevls
Copy link
Contributor

This makes me sad, but it will make me far less sad in the long term than seeing builds fail all the time. 😹

achille-roussel
achille-roussel approved these changes Feb 21, 2019
View reviewed changes
Copy link
Contributor

@achille-roussel achille-roussel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of that!

I was thinking we could run the test multiple times until it passes as well, but this may be less dirty :)

@stevevls stevevls merged commit 809ee76 into master Feb 21, 2019
@stevevls stevevls deleted the fix_racy_reader_stats_test branch February 21, 2019 21:02
@stevevls
Copy link
Contributor Author

@achille-roussel I love the "keep running it until it passes" idea. 😹

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjenkins rjenkins rjenkins approved these changes

@achille-roussel achille-roussel achille-roussel approved these changes

@Pryz Pryz Awaiting requested review from Pryz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stevevls @achille-roussel @rjenkins