Bucket destination: trackingKey -> publishableKey #2039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joe-ayoub-segment
approved these changes
May 16, 2024
|
hi @roncohen - could you run this command and commit the result please? ./bin/run generate:types Thanks, |
|
Thanks @joe-ayoub-segment. Seems to not really generate anything new: 
|
|
OK interesting, thanks @roncohen. I'll fix whatever the issue is when I merge for deploy. |
|
thanks @joe-ayoub-segment! |
|
hi @roncohen this PR has been deployed. Can you confirm that you are happy with the changes please? |
|
@joe-ayoub-segment I can confirm that the UI updates have deployed as expected. Than you for your help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At Bucket we're changing the terminology around keys from
tracking keytopublishable key. I've avoided updating the internals to reflect the terminology change to avoid needing to migrate the existing install base. That means changes in this PR are purely cosmetical.