Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EN-1033] Handle root level mapping #2026

Merged
merged 6 commits into from
May 9, 2024
Merged

Conversation

valerieernst
Copy link
Contributor

@valerieernst valerieernst commented May 7, 2024

A summary of your pull request, including the what change you're making and why.

Adding support for the new __segment_internal_directive mapping field. Details in this RFC

Testing

Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [Segmenters] Tested in the staging environment

@valerieernst valerieernst marked this pull request as ready for review May 8, 2024 22:00
@valerieernst valerieernst requested a review from a team May 8, 2024 22:00
@valerieernst valerieernst requested a review from a team as a code owner May 8, 2024 22:00
@valerieernst valerieernst requested review from dlasky and pooyaj May 8, 2024 22:00
Copy link
Contributor

@pooyaj pooyaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢🚢

@valerieernst valerieernst merged commit 70ed719 into main May 9, 2024
11 checks passed
@valerieernst valerieernst deleted the handle-root-level-mapping branch May 9, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants