fix: properly serialize & unserialize errors across processes #1391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewmueller
force-pushed
the
fix/serialize-errors
branch
from
442cc2a to
8304e4e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a BREAKING change and builds upon this PR #1390.
This PR fixes #646 and cleans up some of the adhoc error handling we've been doing.
I've chosen to add error serialization & unserialization at the IPC-level. This makes the IPC more opinionated (errors must always come first), but it allows us to transport errors across processes gracefully. Since nightmare already considered errors as the first argument everywhere, I didn't have to change much.
In addition to #1390, this is a breaking change because now promises that are rejected will always return
Errortypes, whereas before sometimes we were returning objects, sometimes strings, sometimes{}. This is a minor breaking change, but warrants the3.0.0bump.