Skip to content
This repository has been archived by the owner on Mar 17, 2024. It is now read-only.

Helm Chart: Fix ServiceMonitor Interval Type To String #102

Merged
merged 1 commit into from
Dec 3, 2019

Conversation

abhishekjiitr
Copy link
Contributor

Fix prometheus.serviceMonitor.interval type from integer to string in the default values.
Otherwise enabling ServiceMonitor in the helm chart results in an error like this:

Error: release kafka-lag-exporter failed: ServiceMonitor.monitoring.coreos.com "kafka-lag-exporter" is invalid: []: Invalid value: map[string]interface {}{"kind":"ServiceMonitor", "metadata":map[string]interface {}{"generation":1, "uid":"76063bad-0cf5-11ea-8416-0cc47a338560", "name":"kafka-lag-exporter", "namespace":"monitoring", "creationTimestamp":"2019-11-22T06:58:17Z", "labels":map[string]interface {}{"app":"kafka-lag-exporter", "app.kubernetes.io/instance":"kafka-lag-exporter", "app.kubernetes.io/managed-by":"Tiller", "app.kubernetes.io/name":"kafka-lag-exporter", "helm.sh/chart":"kafka-lag-exporter-0.5.6"}}, "spec":map[string]interface {}{"endpoints":[]interface {}{map[string]interface {}{"port":"http", "interval":30}}, "jobLabel":"jobLabel", "namespaceSelector":map[string]interface {}{"matchNames":[]interface {}{"centrallogging"}}, "selector":map[string]interface {}{"matchLabels":map[string]interface {}{"app.kubernetes.io/name":"kafka-lag-exporter", "helm.sh/chart":"kafka-lag-exporter-0.5.6"}}}, "apiVersion":"monitoring.coreos.com/v1"}: validation failure list:
spec.endpoints.interval in body must be of type string: "integer"

Reference: https://github.com/coreos/prometheus-operator/blob/60300f2baf8b02bc86d71672a76420476924af75/example/prometheus-operator-crd/servicemonitor.crd.yaml#L103

@seglo seglo added the bug Something isn't working label Nov 23, 2019
@abhishekjiitr
Copy link
Contributor Author

@seglo can we merge this?

@seglo seglo merged commit 8b805c3 into seglo:master Dec 3, 2019
@seglo
Copy link
Owner

seglo commented Dec 3, 2019

@abhishekjiitr Apologies for the delay. I plan to work on some things and cut a release during the holiday season.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants