fix: add more rules for G204 #677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ccojocar Still WIP but interested to know your thoughts about this fix. |
Codecov Report
@@ Coverage Diff @@
## master #677 +/- ##
==========================================
+ Coverage 69.73% 69.89% +0.15%
==========================================
Files 47 47
Lines 2805 2833 +28
==========================================
+ Hits 1956 1980 +24
- Misses 796 799 +3
- Partials 53 54 +1
Continue to review full report at Codecov.
|
ccojocar
reviewed
Aug 9, 2021
nanikjava
changed the title
ccojocar
approved these changes
Aug 16, 2021
This was referenced Jul 22, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix : #343
This PR fix is to allow
exec.Commandto use parameter pass as part of function.