Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rule ID to default text output template #198

Merged
merged 1 commit into from
Apr 16, 2018
Merged

Add rule ID to default text output template #198

merged 1 commit into from
Apr 16, 2018

Conversation

glb
Copy link
Contributor

@glb glb commented Apr 4, 2018

Since rule IDs are now available (#188), it would be nice for newbies to be able to see them in the default text output and correlate back to documentation.

Before:

[.../database.go:266] - Errors unhandled. (Confidence: HIGH, Severity: LOW)
  > scope.SetColumn(x.DBName, encoded)

After:

[.../database.go:266] - G104: Errors unhandled. (Confidence: HIGH, Severity: LOW)
  > scope.SetColumn(x.DBName, encoded)

This makes it easier to write annotations using #nosec:RuleID as well.

@glb glb force-pushed the add-ruleid-to-text-output branch from 5ff3db1 to 655180e Compare April 4, 2018 21:14
@gcmurphy gcmurphy merged commit b643ac2 into securego:master Apr 16, 2018
@glb glb deleted the add-ruleid-to-text-output branch April 22, 2018 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gcmurphy gcmurphy gcmurphy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@glb @gcmurphy