Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up some mistakes in the README instructions #195

Merged
merged 1 commit into from
Mar 19, 2018
Merged

Fix up some mistakes in the README instructions #195

merged 1 commit into from
Mar 19, 2018

Conversation

ericwb
Copy link
Contributor

@ericwb ericwb commented Mar 15, 2018

This fixes a couple issues found in the README in the development
section:

  • There was no information provided on dependencies. Both go/dep
    and golint are required to run make.
  • To run the tests, the command 'make test' not 'make tests' has
    to be used.

This fixes a couple issues found in the README in the development
section:
* There was no information provided on dependencies.  Both go/dep
  and golint are required to run make.
* To run the tests, the command 'make test' not 'make tests' has
  to be used.
Copy link
Member

@ccojocar ccojocar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gcmurphy gcmurphy merged commit 542d0c0 into securego:master Mar 19, 2018
@ericwb ericwb deleted the readme_fixes branch March 19, 2018 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants