Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build improvments #179

Merged
merged 19 commits into from
Mar 12, 2018
Merged

Build improvments #179

merged 19 commits into from
Mar 12, 2018

Conversation

ccojocar
Copy link
Member

@ccojocar ccojocar commented Feb 22, 2018 •
edited
Loading

  • Add a Makefile which automates the common build tasks
  • Introduce the build information which is injected during build with the help of linker flags
  • Switch from godep to dep for dependencies management
  • Update the build to use the make test target
  • Update the Dockerfile to make easier the usage of gas running in docker container
  • Add the Development section to README file
  • Add Go 1.10 to the build and drop the support for 1.7

Fixes #77

cc @gcmurphy

@ccojocar ccojocar mentioned this pull request Feb 22, 2018
Closed
@gcmurphy
Copy link
Member

gcmurphy commented Mar 5, 2018

This is looking really nice. I'll try to review this properly soon.

@gcmurphy
Copy link
Member

gcmurphy commented Mar 7, 2018

@cosmincojocar tried to review this but am hitting a weird error on my Mac.
(see golang/dep#1738)

If you've got any ideas what I'm messing up let me know.

@gcmurphy
Copy link
Member

gcmurphy commented Mar 8, 2018

Happy with these changes but want to wait until mozilla/tls-observatory#306 or another suitable fix is merged into the mozilla's tls observatory.

ccojocar and others added 19 commits March 11, 2018 10:10
@ccojocar
Add a semantic version to the usage text
c03f2b0
@ccojocar
Add a comment to the version function
c63b61c
@ccojocar
Inject the version, git tag and build date as build variables
21e1e84
@ccojocar
Update README
641d350
@ccojocar
Fix lint warnings
b5ceaf2
@ccojocar
Update README
230eac1
@ccojocar
Manage dependencies with dep tool instead of godep
7954917
@ccojocar
Add a Makefile for common build tasks
5d6eafa
@ccojocar
Update the build file to use the make tool
2ed7dc6
@ccojocar
Update Dockerfile
4d53490
@ccojocar
Add docker entry point in to make the passing of arguments easy
2771efb
@ccojocar
Update README
0d274ec
@ccojocar
Add missing tools to the build
8472273
@ccojocar
Drop 1.7 support and add 1.10
33bcf45
@ccojocar
Fix Go 1.10 according with the travis guidelines
d18879f 
https://docs.travis-ci.com/user/languages/go/
@ccojocar
Update the tls-observatory package
190aa10
@ccojocar
Fix lint warnings
c8a6748
@ccojocar
Change the output of the tests to be more verbose
b157060
@ccojocar
Check if the are build errors before executing the rule test
85d72df
@ccojocar
Copy link
Member Author

@gcmurphy Thanks for following up the build issue with the tls-observatory. It seems that is fixed now. I tried on my Mac, and it works.

@gcmurphy
Copy link
Member

Great thanks for following up!

@gcmurphy gcmurphy merged commit e809226 into securego:master Mar 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ccojocar @gcmurphy