Add a tool to generate the TLS configuration form Mozilla's ciphers recommendation #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Feb 19, 2018
rules/tls_config.go
Outdated
| }, []ast.Node{(*ast.CompositeLit)(nil)} | ||
| } | ||
|
|
||
| // DO NOT EDIT - Generated by tlsconfig |
There was a problem hiding this comment.
comment on exported function NewOldTLSCheck should be of the form "NewOldTLSCheck ..."
rules/tls_config.go
Outdated
| }, []ast.Node{(*ast.CompositeLit)(nil)} | ||
| } | ||
|
|
||
| // DO NOT EDIT - Generated by tlsconfig |
There was a problem hiding this comment.
comment on exported function NewIntermediateTLSCheck should be of the form "NewIntermediateTLSCheck ..."
rules/tls_config.go
Outdated
| "github.com/GoASTScanner/gas" | ||
| ) | ||
|
|
||
| // DO NOT EDIT - Generated by tlsconfig |
There was a problem hiding this comment.
comment on exported function NewModernTLSCheck should be of the form "NewModernTLSCheck ..."
|
Awesome work! |
gcmurphy
pushed a commit
that referenced
this pull request
Mar 8, 2018
* Add a tool to generate the TLS configuration form Mozilla's ciphers recommendation (#178) * Add a tool which generates the TLS rule configuration from Mozilla server side TLS configuration * Update README * Remove trailing space in README * Update dependencies * Fix the commends of the generated functions * Add nil pointer check to rule. (#181) TypeOf returns the type of expression e, or nil if not found. We are calling .String() on a value that may be nil in this clause. Relates to #174 * Add support for YAML output format (#177) * Add YAML output format * Update README * added rule to check for tainted file path * added #nosec to main/issue.go * updated test case import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tool can generate the TLS configuration from Mozilla's ciphers recommendation and it can be invoked with
go generate.The configuration of TLS rule was generated using the tool. I updated also the README file with some instructions how to do this.
Fix #15
cc @gcmurphy