Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2324 Adapt 'location' attribute in Trivy parser to match a URL format #2725

Merged

Conversation

BorisShek
Copy link
Contributor

@BorisShek BorisShek commented Oct 21, 2024

Update the 'location' attribute for the results of the Trivy parser to match a valid self-defined URL format:
scb://<scanner>/?cluster=<cluster>&namespace=<namespace>&kind=<kind>&name=<name>

Description

Checklist

  • Test your changes as thoroughly as possible before you commit them. Preferably, automate your test by unit/integration tests.
  • Make sure that all your commits are signed-off and that you are added to the Contributors file.
  • Make sure that all CI finish successfully.
  • Optional (but appreciated): Make sure that all commits are Verified.

Copy link

netlify bot commented Oct 21, 2024

Deploy Preview for docs-securecodebox canceled.

Name Link
🔨 Latest commit c8ac750
🔍 Latest deploy log https://app.netlify.com/sites/docs-securecodebox/deploys/673cd490dd6cfd00083698f1

@BorisShek BorisShek self-assigned this Nov 8, 2024
@BorisShek BorisShek added documentation Improvements or additions to documentation architecture Architecture changes findings and removed architecture Architecture changes labels Nov 8, 2024
@BorisShek BorisShek force-pushed the scb-2324_trivy_parser_location_as_url branch from 1748ef9 to f379b67 Compare November 8, 2024 15:21
@BorisShek BorisShek linked an issue Nov 19, 2024 that may be closed by this pull request
@BorisShek
Copy link
Contributor Author

Resolves #2324

Adapt the 'location' attribute for the results of the Trivy parser to a valid self-defined URL format.
Fix a small syntax error in SecureCodeBoxFindingsToDefectDojoMapper.

Signed-off-by: Boris Shek <boris.shek@iteratec.com>
…Trivy parser

Update the test snapshot file to match the new 'location' attribute URL format in the results of the Trivy parser.

Signed-off-by: Boris Shek <boris.shek@iteratec.com>
… Trivy parser

Adapt 'location' attribute for ImageScanResults of Trivy parser to match a URL format.
Adapt URL parameter names of 'location' attribute to match the attribute names of scan results (Before: "?cluster=..."; After: "?ClusterName=...").
Update test snapshot to match the current changes of 'location' format.

Signed-off-by: Boris Shek <boris.shek@iteratec.com>
…URL format for the 'location' attribute

Signed-off-by: Boris Shek <boris.shek@iteratec.com>
@BorisShek BorisShek force-pushed the scb-2324_trivy_parser_location_as_url branch from ba7f6a9 to e00ea93 Compare November 19, 2024 18:05
…format for the 'location' attribute

Signed-off-by: Boris Shek <boris.shek@iteratec.com>
@BorisShek BorisShek marked this pull request as ready for review November 19, 2024 19:31
@J12934 J12934 merged commit ed0af28 into secureCodeBox:main Nov 28, 2024
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation findings
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Trivy Parser Creates Malformed Location URL
2 participants