Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix documentation findings #1878

Merged
merged 1 commit into from
Aug 25, 2023
Merged

Fix documentation findings #1878

merged 1 commit into from
Aug 25, 2023

Conversation

Zero3141
Copy link
Contributor

Description

Rename all findings.json files in the scanner examples to findings.yaml. This allows the documentation to show it in a Tab next to the scan definition

Checklist

  • Test your changes as thoroughly as possible before you commit them. Preferably, automate your test by unit/integration tests.
  • Make sure that all your commits are signed-off and that you are added to the Contributors file.
  • Make sure that all CI finish successfully.
  • Optional (but appreciated): Make sure that all commits are Verified.

@Zero3141 Zero3141 added the documentation Improvements or additions to documentation label Aug 25, 2023
@Zero3141 Zero3141 requested a review from Ilyesbdlala August 25, 2023 12:22
@Zero3141 Zero3141 self-assigned this Aug 25, 2023
@Zero3141 Zero3141 force-pushed the fix/documentation-findings branch from 88f4247 to ef3b40b Compare August 25, 2023 14:34
@Zero3141 Zero3141 changed the base branch from main to bugfix/amass-parser August 25, 2023 14:59
@Zero3141 Zero3141 changed the base branch from bugfix/amass-parser to main August 25, 2023 14:59
@Ilyesbdlala
Rename findings.json to yaml to support display in documentation
4d95667 
Signed-off-by: Heiko Kiesel <heiko.kiesel@iteratec.com>
@Ilyesbdlala Ilyesbdlala force-pushed the fix/documentation-findings branch from ef3b40b to 4d95667 Compare August 25, 2023 15:03
@Zero3141 Zero3141 enabled auto-merge (rebase) August 25, 2023 15:04
@Zero3141 Zero3141 merged commit 70b26cd into secureCodeBox:main Aug 25, 2023
@Zero3141 Zero3141 deleted the fix/documentation-findings branch September 4, 2023 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@J12934 J12934 J12934 approved these changes

@Ilyesbdlala Ilyesbdlala Awaiting requested review from Ilyesbdlala

Assignees

@Zero3141 Zero3141

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zero3141 @J12934