Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run Helm docs generation only on main branch #1291

Merged
merged 1 commit into from
Sep 2, 2022

Conversation

Ilyesbdlala
Copy link
Member

@Ilyesbdlala Ilyesbdlala commented Jul 28, 2022

Description

Changed the trigger to only the main branch.
To allow pushing to main. a PAT with admin privileges is required.
secrets.PAT_WITH_ADMIN is currently a placeholder.
closes https://github.com/secureCodeBox/internal/issues/62

A different “solution” would be to disable PGP signing for the helm-bot. This would no longer require access to main repo secrets and allow helm-bot to run on forks.

I tried the suggestions mentioned in the git-auto-commit Action documentation. AFAIK, they do not fit our use-case. (#1294)

Changed the trigger to only the main branch.
To allow pushing to main. a PAT with admin privileges is required.
secrets.PAT_WITH_ADMIN is currently a placeholder.

Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
@github-actions
Copy link

github-actions bot commented Jul 28, 2022

MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 1 0 0.04s
✅ GIT git_diff yes no 0.17s
✅ SPELL misspell 1 0 0.03s
⚠️ YAML prettier 1 1 0.56s
✅ YAML v8r 1 0 1.43s
✅ YAML yamllint 1 0 0.13s

See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

@rseedorff rseedorff added this to the v3.15.0 milestone Aug 31, 2022
@rseedorff rseedorff marked this pull request as ready for review September 2, 2022 15:29
@rseedorff rseedorff merged commit 4953225 into main Sep 2, 2022
@rseedorff rseedorff deleted the maintenance/helm-on-main-push-only branch September 2, 2022 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants