ADR-0012: Initial Proposal for Cluster Wide Custom Resources (e.g. ClusterScanType) #1270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ype) Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
J12934
added
documentation
MegaLinter status:
|
| Descriptor | Linter | Files | Fixed | Errors | Elapsed time |
|---|---|---|---|---|---|
| actionlint | 4 | 3 | 0.37s | ||
| bash-exec | 14 | 4 | 0.06s | ||
| shellcheck | 14 | 18 | 0.21s | ||
| shfmt | 14 | 14 | 0.01s | ||
| dockerfilelint | 3 | 1 | 0.87s | ||
| hadolint | 3 | 2 | 0.17s | ||
| ✅ GIT | git_diff | yes | no | 0.16s | |
| golangci-lint | 11 | 11 | 17.29s | ||
| revive | 11 | 4 | 0.18s | ||
| checkstyle | 2 | 2 | 5.01s | ||
| eslint | 9 | 1 | 0.66s | ||
| ✅ JSON | eslint-plugin-jsonc | 9 | 0 | 2.72s | |
| ✅ JSON | jsonlint | 9 | 0 | 3.21s | |
| prettier | 9 | 1 | 1.51s | ||
| ✅ JSON | v8r | 9 | 0 | 17.94s | |
| bandit | 36 | 24 | 0.99s | ||
| black | 36 | 1 | 4.18s | ||
| flake8 | 36 | 869 | 1.23s | ||
| isort | 36 | 24 | 0.24s | ||
| pylint | 36 | 72 | 11.58s | ||
| misspell | 326 | 1 | 2.28s | ||
| eslint | 3 | 1 | 0.36s | ||
| prettier | 233 | 1 | 15.66s | ||
| v8r | 233 | 6 | 302.05s | ||
| yamllint | 233 | 1 | 27.85s |
See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff
SebieF
requested changes
Jul 19, 2022
https://github.blog/changelog/2022-06-08-admins-can-require-sign-off-on-web-based-commits/ Co-authored-by: Sebastian Franz <32578476+SebieF@users.noreply.github.com> Signed-off-by: Jannik Hollenbach <jannik@hollenbach.de>
Co-authored-by: Sebastian Franz <32578476+SebieF@users.noreply.github.com> Signed-off-by: Jannik Hollenbach <jannik@hollenbach.de>
Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
SebieF
previously approved these changes
Jul 20, 2022
Signed-off-by: Max Maass <max.maass@iteratec.com>
|
I just added a second proposal to the ADR, which features stricter separation between cluster-wide resources and namespace-local ones. I will discuss this with @J12934 to complete the "TBD" parts before we can bring this to the rest of the team for discussion. |
Signed-off-by: Max Maass <max.maass@iteratec.com>
Signed-off-by: Max Maass <max.maass@iteratec.com>
Signed-off-by: Max Maass <max.maass@iteratec.com>
Weltraumschaf
changed the title
Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
@malexmave I don't think this can cause problems: There are following options to install the Cascading Scans hook after the PR all should be ok: 1. As a normal `ScanCompletionHook`, behaving exactly like it does now 2. As a `ClusterScanCompletionHook` *without* an `executionNamespace`. Would use cluster cascading rules and start the cascaded scans in the scans namespace. 3. As a `ClusterScanCompletionHook` *with* an `executionNamespace`. Would use cluster cascading rules and start the cascaded scans in the scans namespace. (this is already explicitly stated in the proposal) If I'm overlooking something feel free to revert this commit :) Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contain a Proposal for new variants for some of our CustomResourceDefinitions which could be used on a cluster level and then be reused across namespaces.