Coverage decreased (-0.71%) when pulling 4713a40 on matthewbogner:idle-connection-reaping into 68975bc on searchbox-io:master.

Hi Matthew,

Thanks a lot for the contribution 🍻 me or some other committer will have a look at the changes as soon as we have the time. In the meantime what is the problem you are having with tests? In the past some of the tests were not properly isolated so running them on parallel created problems but I have not run into this problem recently.

Hey @kramer , here is a gist of the test failures I am seeing locally. I did a netstat and ps at the beginning of the gist to show that I have no elasticsearch nodes running locally when I run "mvn clean verify"

https://gist.github.com/matthewbogner/fb11db12dad3c6a5b509

These are the failing tests:

Failed tests: 
  JestClientFactoryIntegrationTest.testDiscovery:34->Assert.assertEquals:555->Assert.assertEquals:118->Assert.failNotEquals:743->Assert.fail:88 All 4 nodes should be discovered and be in the client's server list expected:<4> but was:<1>

Tests in error: 
  CloseIndexIntegrationTest.testClose:33 » Socket Invalid argument
  FlushIntegrationTest.testFlushSpecificIndices:51 » Socket Invalid argument
  GetMappingIntegrationTest.testWithSingleIndex:61 » Socket Invalid argument
  GetMappingIntegrationTest.testWithMultipleIndices:81 » Socket Invalid argument
  StatsIntegrationTest.testDefaultStats:32 » NullPointer
  TypeExistIntegrationTest.indexTypeExists:34 » Socket Invalid argument

Could you try with -Djava.net.preferIPv4Stack=true flag? (also do you have multiple network interfaces by any chance?)

I tried with the additional JVM flag and got the same results. I do have several network interfaces - one of which is a VPN connection. I tried both with my VPN on and also with it off and get the same failing results.

I'll try and take some time today and figure out in more detail what exactly is going on.

Yup VPN caused the same problem for me in the past but things were back to normal once I turned VPN connection off. Actual reason probably have something to with routing/name resolution handling with multiple NICs in Java but I was too lazy to do any further research.

Turns out that the test suite doesn't like to be run with java 1.7.0_51 on OSX Mavericks. I updated to 1.7.0_67 and had better luck with "mvn clean verify".

However...

I authored some tests which run just fine locally, but Travis is either having issues or disagrees with the quality of my tests. In both builds, the logs reached a 4mb limit and the build got terminated. 🎰

The quantity of "Connection Refused" exceptions coming from the NodeChecker is kind of staggering while running the tests.

Coverage decreased (-0.23%) when pulling f0b47ed on matthewbogner:idle-connection-reaping into 68975bc on searchbox-io:master.

Coverage decreased (-0.23%) when pulling f587e90 on matthewbogner:idle-connection-reaping into 68975bc on searchbox-io:master.

Thanks again for all your efforts @matthewbogner ! 🍻

Awesome, thank you. Are you guys planning another maven central build/release anytime soon?

Yup - as tracked on Changelog.