Make execute method on WASM client for compatibility with async_impl #989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The async_impl of reqwest has a `execute` impl on Client which is used to execute a request and return a Result Future. When converting a crate from async to wasm this method is missing, requiring forking and rewriting the crate. By introducing this method less errors will be introduced when trying to compile to wasm
Nutomic
pushed a commit
to Nutomic/reqwest
that referenced
this pull request
Nov 7, 2024
…eanmonstar#989) The async_impl of reqwest has a `execute` impl on Client which is used to execute a request and return a Result Future. When converting a crate from async to wasm this method is missing, requiring forking and rewriting the crate. By introducing this method less errors will be introduced when trying to compile to wasm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The async_impl of reqwest has a
executeimpl on Client which is used to execute a request and return a Result Future. When building a async crate to wasm this method is missing, requiring forking and rewriting the crate.I'm not aware of any reason why this method should be missing, but if there was a good reason for leaving the
executemethod please say so. The same if you require any changes!