Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make pool idle timeout configurable #866

Merged
merged 1 commit into from
May 22, 2020
Merged

Make pool idle timeout configurable #866

merged 1 commit into from
May 22, 2020

Conversation

pluehne
Copy link
Contributor

@pluehne pluehne commented Mar 28, 2020

hyper’s ClientBuilder has an option to define the idle timeout of the connection pool. As it’s quite useful to be able to modify this value, this patch extends reqwest’s ClientBuilder to expose that option as well. The default value of 90 seconds is taken from hyper.

Copy link
Owner

@seanmonstar seanmonstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this (and sorry for my absence)! Just one thought if you're still around.

src/async_impl/client.rs Outdated Show resolved Hide resolved
@pluehne pluehne requested a review from seanmonstar May 22, 2020 13:54
hyper’s ClientBuilder has an option to define the idle timeout of the
connection pool. As it’s quite useful to be able to modify this value,
this patch extends reqwest’s ClientBuilder to expose that option as
well. The default value of 90 seconds is taken from hyper.
@pluehne
Copy link
Contributor Author

pluehne commented May 22, 2020

@seanmonstar: I renamed the option as you had suggested, and I opened a separate pull request (#917) to rename max_idle_per_host accordingly.

Copy link
Owner

@seanmonstar seanmonstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@seanmonstar seanmonstar merged commit b5706f2 into seanmonstar:master May 22, 2020
@pluehne pluehne deleted the expose-pool-idle-timeout-configuration branch May 22, 2020 14:50
@pluehne
Copy link
Contributor Author

pluehne commented May 22, 2020

Awesome, thanks for reviewing and merging this, @seanmonstar!

Nutomic pushed a commit to Nutomic/reqwest that referenced this pull request Nov 7, 2024
hyper’s ClientBuilder has an option to define the idle timeout of the
connection pool. As it’s quite useful to be able to modify this value,
this patch extends reqwest’s ClientBuilder to expose that option as
well. The default value of 90 seconds is taken from hyper.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants