Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing Identity::from_pem for PKCS1 RSA private keys #458

Merged
merged 1 commit into from
Feb 16, 2019
Merged

Fixing Identity::from_pem for PKCS1 RSA private keys #458

merged 1 commit into from
Feb 16, 2019

Conversation

mavax
Copy link
Contributor

@mavax mavax commented Feb 16, 2019

If a PKCS8 private key is not found, rustls:internal::pemfile::pkcs8_private_keys returns Ok with an empty slice of keys. This means rustls::internal::pemfile::rsa_private_keys never gets called.

I wrote a test to reproduce the issue.

@seanmonstar seanmonstar merged commit f96f945 into seanmonstar:master Feb 16, 2019
@seanmonstar
Copy link
Owner

Thanks for catching this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mavax @seanmonstar