Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add is_connect on error #1023

Merged
merged 5 commits into from
Sep 3, 2020
Merged

Add is_connect on error #1023

merged 5 commits into from
Sep 3, 2020

Conversation

shuoli84
Copy link
Contributor

@shuoli84 shuoli84 commented Sep 1, 2020

fix #1022

seanmonstar
seanmonstar approved these changes Sep 3, 2020
View reviewed changes
Copy link
Owner

@seanmonstar seanmonstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@seanmonstar seanmonstar merged commit e06e198 into seanmonstar:master Sep 3, 2020
Nutomic pushed a commit to Nutomic/reqwest that referenced this pull request Nov 7, 2024
@shuoli84 @seanmonstar @Nutomic
Add is_connect on error (seanmonstar#1023)
b063063 
* error: add is_connect helper function

* test: ensure request_timeout is not connect_timeout

* fmt

* skip err is_connect if target_arch is wasm. rerun checks

Co-authored-by: lishuo <lishuo.03@bytedance.com>
Co-authored-by: Sean McArthur <sean@seanmonstar.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanmonstar seanmonstar seanmonstar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Question] How to tell if timeout is caused by Connect?
2 participants
@shuoli84 @seanmonstar