feature: use 'uname -n' instead of 'hostname' to get hostname #2197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #2197 +/- ##
==========================================
- Coverage 20.19% 7.27% -12.93%
==========================================
Files 98 165 +67
Lines 9100 13452 +4352
==========================================
- Hits 1838 978 -860
- Misses 7008 12332 +5324
+ Partials 254 142 -112
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kakaZhou719
reviewed
Apr 23, 2023
Daz-3ux
force-pushed
the
generalname
branch
3 times, most recently
from
b966892 to
05fcaa8
Compare
|
@Daz-3ux ,pls rebase your code. failed |
github-actions
bot
added
ImageBuilding
github-actions
bot
removed
ImageBuilding
fixes: sealerio#2194 The `hostname` command may need to be downloaded on some machines, but the `uname` command is always present. Signed-off-by: Pengda Yang <daz-3ux@proton.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
The
hostnamecommand may need to be downloaded on some machines, but theunamecommand is always present.Does this pull request fix one issue?
Fixes: #2194