support launch app via its name though clusterfile or cli #1917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Clusterfile
ImageBuilding
starnop
reviewed
Dec 16, 2022
types/api/v2/cluster_types.go
Outdated
| Hosts []Host `json:"hosts,omitempty"` | ||
| SSH v1.SSH `json:"ssh,omitempty"` | ||
| // APPNames This field allows user to specify the app name they want to run launch. | ||
| APPNames []string `json:"appNames"` |
starnop
reviewed
Dec 16, 2022
pkg/cluster-runtime/apps.go
Outdated
| func GetImageDefaultLaunchCmds(extension v12.ImageExtension) []string { | ||
| rawCmds := extension.Launch.Cmds | ||
| appNames := extension.Launch.AppNames | ||
| // if raw cmds exist in extension, return it. |
There was a problem hiding this comment.
In my opinion, the launch applications should take precedence over cmds, and we can even mark cmd deprecated in the future because the app can completely override cmd's capabilities
kakaZhou719
force-pushed
the
feat-support-run-app-via-appname
branch
from
0911fec to
19e13a3
Compare
starnop
reviewed
Dec 16, 2022
cmd/sealer/cmd/cluster/run-app.go
Outdated
| }, | ||
| } | ||
|
|
||
| appFlags = &types.APPFlags{} | ||
| runAppCmd.Flags().StringSliceVar(&appFlags.LaunchCmds, "cmds", []string{}, "override default LaunchCmds of clusterimage") | ||
| runAppCmd.Flags().StringSliceVar(&appFlags.Cmds, "cmds", []string{}, "override default LaunchCmds of clusterimage") | ||
| runAppCmd.Flags().StringSliceVar(&appFlags.AppNames, "app-names", []string{}, "override default AppNames of clusterimage") |
kakaZhou719
force-pushed
the
feat-support-run-app-via-appname
branch
from
19e13a3 to
f0abbe3
Compare
Codecov ReportBase: 21.52% // Head: 21.37% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1917 +/- ##
==========================================
- Coverage 21.52% 21.37% -0.16%
==========================================
Files 80 80
Lines 7415 7430 +15
==========================================
- Hits 1596 1588 -8
- Misses 5605 5629 +24
+ Partials 214 213 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
kakaZhou719
force-pushed
the
feat-support-run-app-via-appname
branch
from
f0abbe3 to
328fde4
Compare
starnop
reviewed
Dec 16, 2022
| @@ -230,7 +230,7 @@ func getApplicationType(sources []string) (string, []string, error) { | |||
|
|
|||
| ish, helmErr := isHelm(sources...) | |||
starnop
approved these changes
Dec 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
sealer store some basic information about the cluster image in the image's annotations, such as cluster image type, applications list and its launch commands in one field .
however, we cannot accurately find the application launch command based on its name and all launch commands generate from "APP" instruction is mixed with the "CMDS" instruction in "launch.cmds" filed .
Therefore, I recommend that we only save the relevant information of the application during the build stage and control the launch logic of the application image during the run stage.
Does this pull request fix one issue?
Describe how you did it
Describe how to verify it
Special notes for reviews