The plugins are also deployed when 'Sealer join' is executed #1238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fanux
reviewed
Mar 15, 2022
apply/processor/scale.go
Outdated
| s.MountRootfs, | ||
| s.GetPhasePluginFunc(plugin.PhasePreInit), | ||
| s.Join, | ||
| s.GetPhasePluginFunc(plugin.PhasePreGuest), |
There was a problem hiding this comment.
Join should not exec preguest plugins.
|
Maybe we need PreJoin phase, and only exec PreJoin plugins when join master or nodes. Support multi phase: |
great |
bxy4543
force-pushed
the
fix/deploy_plugins_when_join
branch
from
0b38f4d to
d30790f
Compare
support multiple phase;
bxy4543
force-pushed
the
fix/deploy_plugins_when_join
branch
from
d30790f to
05a4fa2
Compare
fanux
reviewed
Mar 21, 2022
apply/processor/scale.go
Outdated
| s.MountRootfs, | ||
| s.GetPhasePluginFunc(plugin.PhasePreJoin), | ||
| s.Join, | ||
| s.GetPhasePluginFunc(plugin.PhasePostInstall), |
There was a problem hiding this comment.
I think only exec PhasePreJoin and PhasePostJoin
bxy4543
force-pushed
the
fix/deploy_plugins_when_join
branch
from
b1c1ec8 to
185f0eb
Compare
fanux
approved these changes
Mar 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The plugins are also deployed when 'Sealer join' is executed