-
Notifications
You must be signed in to change notification settings - Fork 157
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: sds/mock_redis
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.46.0
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: sds/mock_redis
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.48.1
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 7 commits
- 69 files changed
- 3 contributors
Commits on Nov 27, 2024
-
This is an attempt to fix #281. This PR was also tested using the test suite of our service. There are a few decisions I made regarding this PR, please let me know if it's not appropriate: 1. Error from Redis now contains the redis connection URL - To fix this, I created `MockRedis::Error` module which decorate `Redis::CommandError` and related errors with the connection URL - I replace most of the `Redis::CommandError` with the new module wrapper 2. Some methods now return integer as output instead of boolean and `exists_returns_integer` is removed - I replace the output as is 3. Interfaces of most data structures (Hash, Set, ...) now validate type to be 4 main primitive types - `assert_type` is added to validate the arguments. Currently it doesn't look very clean, so any improvements would be great. 4. `sadd`, `srem` now support multiple arguments 5. Transaction: `multi` now needs to call with a block and `discard`/`exec` cannot be called outside that block anymore - I tried to refactor the logic to make the tests pass, but I'm not entirely confident that it works correctly
Configuration menu - View commit details
-
Copy full SHA for 615c184 - Browse repository at this point
Copy the full SHA 615c184View commit details -
Configuration menu - View commit details
-
Copy full SHA for 465a0e2 - Browse repository at this point
Copy the full SHA 465a0e2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 69484fe - Browse repository at this point
Copy the full SHA 69484feView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7a2677f - Browse repository at this point
Copy the full SHA 7a2677fView commit details -
Configuration menu - View commit details
-
Copy full SHA for cc61aed - Browse repository at this point
Copy the full SHA cc61aedView commit details
Commits on Dec 2, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 7a6447c - Browse repository at this point
Copy the full SHA 7a6447cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9ae5e91 - Browse repository at this point
Copy the full SHA 9ae5e91View commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v0.46.0...v0.48.1