Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: sds/mock_redis
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.46.0
Choose a base ref
...
head repository: sds/mock_redis
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.48.1
Choose a head ref
  • 7 commits
  • 69 files changed
  • 3 contributors

Commits on Nov 27, 2024

  1. Support Redis-rb v5 (#314)

    This is an attempt to fix #281.
    This PR was also tested using the test suite of our service.
    
    There are a few decisions I made regarding this PR, please let me know
    if it's not appropriate:
    
    1. Error from Redis now contains the redis connection URL
    - To fix this, I created `MockRedis::Error` module which decorate
    `Redis::CommandError` and related errors with the connection URL
    - I replace most of the `Redis::CommandError` with the new module
    wrapper
    2. Some methods now return integer as output instead of boolean and
    `exists_returns_integer` is removed
      - I replace the output as is
    3. Interfaces of most data structures (Hash, Set, ...) now validate type
    to be 4 main primitive types
    - `assert_type` is added to validate the arguments. Currently it doesn't
    look very clean, so any improvements would be great.
    4. `sadd`, `srem` now support multiple arguments
    5. Transaction: `multi` now needs to call with a block and
    `discard`/`exec` cannot be called outside that block anymore
    - I tried to refactor the logic to make the tests pass, but I'm not
    entirely confident that it works correctly
    hieuk09 authored Nov 27, 2024
    Configuration menu
    Copy the full SHA
    615c184 View commit details
    Browse the repository at this point in the history
  2. Cut version 0.47.0 (#315)

    sds authored Nov 27, 2024
    Configuration menu
    Copy the full SHA
    465a0e2 View commit details
    Browse the repository at this point in the history
  3. Update .mailmap (#316)

    sds authored Nov 27, 2024
    Configuration menu
    Copy the full SHA
    69484fe View commit details
    Browse the repository at this point in the history
  4. Add LMPOP (#311)

    Currently failing due to needing redis-rb v5 (see also #281 and #293)
    Palladinium authored Nov 27, 2024
    Configuration menu
    Copy the full SHA
    7a2677f View commit details
    Browse the repository at this point in the history
  5. Cut version 0.48.0 (#317)

    sds authored Nov 27, 2024
    Configuration menu
    Copy the full SHA
    cc61aed View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2024

  1. Configuration menu
    Copy the full SHA
    7a6447c View commit details
    Browse the repository at this point in the history
  2. Cut version 0.48.1 (#320)

    sds authored Dec 2, 2024
    Configuration menu
    Copy the full SHA
    9ae5e91 View commit details
    Browse the repository at this point in the history
Loading