Minor improvements to initial message #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit makes the following changes: - Only render the date of last modification if jq is installed. This is not the case when running on a newly flashed RPi Lite, resulting in a blank date being shown. Most users are assumed running by piping to a shell anyway. - Fix a minor typo, and only print a warning for the user to read if lsb_release -c output indicates use of Debian Stretch (EOL). - Tweak the copyright statement (I typically wouldn't worry about it given the size of the changes, but the statement is there, so I figure the right thing to do is to be accurate?)
Grep /etc/os-release for stretch instead of lsb_release.
|
Looks good to me, but @kx1t is the brain behind this so I'll defer to his opinion :) Thank you for this! |
It's our policy that only the main file's author is mentioned in any of the files and scripts of the sdr-enthusiasts organization; all other contributors are mentioned as such automatically in the Github repo when they make changes and/or file a PR.
|
I'm all good with this -- thanks for the changes. I reverted only 1 thing: bff21cc It's our policy that only the main file's author is mentioned in any of the files and scripts of the sdr-enthusiasts organization; all other contributors are mentioned as such automatically in the Github repo when they make changes and/or file a PR. |
kx1t
approved these changes
Oct 18, 2023
|
Understood - copyright preambles aren't something I've encountered much until now, and everyone does things a little differently. Thanks all for your patience while I find my feet and for your time in reviewing :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes the following changes:
Only render the date of last modification if jq is installed. This is not the case when running on a newly flashed RPi Lite, resulting in a blank date being shown. Most users are assumed running by piping to a shell anyway.
Fix a minor typo, and only print a warning for the user to read if /etc/os-release indicates use of Debian Stretch (EOL).
Tweak the copyright statement (I typically wouldn't worry about it given the size of the changes, but the statement is there, so I figure the right thing to do is to be accurate?)