Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added eslint + standard config #25

Merged
merged 5 commits into from
Mar 31, 2017
Merged

Added eslint + standard config #25

merged 5 commits into from
Mar 31, 2017

Conversation

bali182
Copy link
Contributor

@bali182 bali182 commented Mar 30, 2017

But it's currently commented out in .travis.yml since we have a few issues and I didn't want to perform the surgery

@bali182 bali182 mentioned this pull request Mar 30, 2017
Closed
@bali182
Copy link
Contributor Author

bali182 commented Mar 30, 2017

Errors were small, fixed them anyways

@sdgluck
Copy link
Owner

sdgluck commented Mar 30, 2017

Looks good! I guess we should add npm run lint before the build step in the prepublishOnly script.

@bali182
Copy link
Contributor Author

bali182 commented Mar 30, 2017

Done ☑️

@sdgluck
Copy link
Owner

sdgluck commented Mar 31, 2017

Awesome - thanks!

@sdgluck sdgluck merged commit d4190df into sdgluck:master Mar 31, 2017
@bali182 bali182 deleted the eslint branch March 31, 2017 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bali182 @sdgluck