Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw an error on defineProperty setPrototypeOf deleteProperty mutations #21

Merged
merged 1 commit into from
Mar 29, 2017
Merged

Throw an error on defineProperty setPrototypeOf deleteProperty mutations #21

merged 1 commit into from
Mar 29, 2017

Conversation

dcamilleri
Copy link
Contributor

Following our discussion on this thread #15, I handled the Object.defineProperty, Object.setPrototypeOf and delete mutations on the mewt objects.

I removed the set trap, as the defineProperty handles it as well (thanks @sscotth for the link)

I followed @bali182 advice for creating for proxy handler.

Let me know what you think.

@sdgluck
Copy link
Owner

sdgluck commented Mar 29, 2017

Thanks, this looks good! Would you mind rebasing onto master and amending the tests accordingly, as we switched to using Jest during your work. There may also be some changes to index.js that are conflicting. Apologies for the inconvenience.

@dcamilleri
Copy link
Contributor Author

No problem, just rebased the branch with master ! :)

@sdgluck sdgluck merged commit 874c5e4 into sdgluck:master Mar 29, 2017
@sdgluck
Copy link
Owner

sdgluck commented Mar 29, 2017 •
edited
Loading

Sweet. Thanks! 👍

@sdgluck sdgluck mentioned this pull request Mar 30, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dcamilleri @sdgluck