Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IMAGES: Adding Sinister Six screenshots #242

Merged
merged 1 commit into from
Jun 8, 2022
Merged

IMAGES: Adding Sinister Six screenshots #242

merged 1 commit into from
Jun 8, 2022

Conversation

SupSuper
Copy link
Contributor

https://bugs.scummvm.org/ticket/13321

Marvel Comics Spider-Man: The Sinister Six (DOS/German)

@Thunderforge
Copy link
Contributor

image

@Thunderforge Thunderforge self-requested a review May 16, 2022 02:33
Thunderforge
Thunderforge requested changes May 16, 2022
View reviewed changes
Copy link
Contributor

@Thunderforge Thunderforge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While J. Jonah Jameson may want lots of pictures of Spider-Man, our ScummVM guidelines say we only need a few.

For each game, we would like to have a small (say, between 2 and 5) number of screenshots which give users a good idea of what the game looks like to play. If the game is available in different languages or versions, it would also be nice to have a screenshot or two showing the differences of those versions.

Please reduce the count to no more than 10.

@neuromancer
Copy link
Contributor

I can select 10 images (removing uninteresting and spoilery ones), but I don't have edit permission for @SupSuper's branch so I will only list the image filenames here.

@neuromancer
Copy link
Contributor

These should be fine:

  • sinistersix_dos_de_01.jpg
  • sinistersix_dos_de_03.jpg
  • sinistersix_dos_de_05.png
  • sinistersix_dos_de_06.jpg
  • sinistersix_dos_de_11.png
  • sinistersix_dos_de_13.png
  • sinistersix_dos_de_14.png
  • sinistersix.png (logo)

@sev-
Copy link
Member

sev- commented May 31, 2022

Wiki says between 2 and 5, NOT 10. Screenshots are rotated on the front page and we want all games to be represented equally.

@SupSuper
Copy link
Contributor Author

SupSuper commented Jun 1, 2022

Down to 5.

@Thunderforge Thunderforge self-requested a review June 8, 2022 23:06
@Thunderforge
Copy link
Contributor

image

Thanks for submitting!

@Thunderforge Thunderforge merged commit 1f9a528 into scummvm:master Jun 8, 2022
@Thunderforge
Copy link
Contributor

Didn't realize until afterwards, but the filenames were missing the variant number (1). I fixed it in b86ccd8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thunderforge Thunderforge Thunderforge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SupSuper @Thunderforge @neuromancer @sev-