Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IMAGES: Adding Blazing Dragons screenshots #241

Merged
merged 1 commit into from
Jun 8, 2022

Conversation

SupSuper
Copy link
Contributor

https://bugs.scummvm.org/ticket/12433

Blazing Dragons (Sony Playstation/English (US))

Copy link
Contributor

@Thunderforge Thunderforge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the wiki:

For each game, we would like to have a small (say, between 2 and 5) number of screenshots which give users a good idea of what the game looks like to play.

This PR has too many screenshots. Can you cull it down to no more than 10?

@sev-
Copy link
Member

sev- commented May 31, 2022

Not more than 5 per game, please. Wiki is clear here.

@SupSuper
Copy link
Contributor Author

SupSuper commented Jun 1, 2022

Down to 5.

@Thunderforge
Copy link
Contributor

Looks great! I especially like how several of them have English text, clearly indicating that this is the English version.

@Thunderforge Thunderforge merged commit 17152e9 into scummvm:master Jun 8, 2022
@Thunderforge
Copy link
Contributor

Thunderforge commented Jun 8, 2022

I didn't notice this until later, but the language in the filename was us. I had to change it to en-us instead ("United States" is not a valid language, but "English - United States" is) in a29a949.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants