Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IMAGES: Adding Myst (Italian) screenshots #235

Merged
merged 1 commit into from
Jun 8, 2022
Merged

IMAGES: Adding Myst (Italian) screenshots #235

merged 1 commit into from
Jun 8, 2022

Conversation

SupSuper
Copy link
Contributor

https://bugs.scummvm.org/ticket/12406

Myst (Windows/Italian)

@Thunderforge
Copy link
Contributor

Just to clarify: are these for the original Myst and not Myst: Masterpiece Edition (or Myst 2021)?

@SupSuper
Copy link
Contributor Author

From the description it should be the original version, and indeed the screenshots seem to still have the original 8-bit artifacting (that was fixed in the Masterpiece Edition).

@Thunderforge Thunderforge self-requested a review May 16, 2022 02:29
Thunderforge
Thunderforge requested changes May 16, 2022
View reviewed changes
Copy link
Contributor

@Thunderforge Thunderforge left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the wiki:

For each game, we would like to have a small (say, between 2 and 5) number of screenshots which give users a good idea of what the game looks like to play.

This PR has 28 screenshots. I know you're not the original author, but can you cull it down to no more than 10? Since the original language is English and other languages were translations, they should probably only be ones that are different in Italian compared to the English game.

@sev-
Copy link
Member

sev- commented May 31, 2022

I would say: cut it down to 2, where Italian will be prominently seen.

Screenshots are rotated on the front page and this will dwarf other games

@sev-
Copy link
Member

sev- commented May 31, 2022

From the same Wiki:

If the game is available in different languages or versions, it would also be nice to have a screenshot or two showing the differences of those versions.

@SupSuper
Copy link
Contributor Author

SupSuper commented Jun 1, 2022 •
edited
Loading

Screenshots are rotated on the front page and this will dwarf other games

This is incorrect, the front page picks a random game first, and only then a random screenshot from it.

Cut down to 2.

@SupSuper
Copy link
Contributor Author

SupSuper commented Jun 1, 2022

Screenshots are rotated on the front page and this will dwarf other games
This is incorrect, the front page picks a random game first, and only then a random screenshot from it.

Cut down to 2.

@Thunderforge
Copy link
Contributor

Looks good, merging.

@Thunderforge Thunderforge merged commit cec03e5 into scummvm:master Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thunderforge Thunderforge Thunderforge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SupSuper @Thunderforge @sev-