Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix exportPNG error with 0x0 canvas #419

Merged
merged 1 commit into from
Apr 28, 2022
Merged

Fix exportPNG error with 0x0 canvas #419

merged 1 commit into from
Apr 28, 2022

Conversation

apple502j
Copy link
Collaborator

Resolves #418

@apple502j apple502j added the bug label Apr 28, 2022
@apple502j apple502j requested a review from tjvr April 28, 2022 14:48
@tjvr
Copy link
Member

tjvr commented Apr 28, 2022

Would it be better to do this inside makeCanvas? Is there ever a use case for a zero-size canvas?

Or is the error only on export?

@apple502j
Copy link
Collaborator Author

@tjvr As far as I'm aware the error only occurs at export time.

tjvr
tjvr approved these changes Apr 28, 2022
View reviewed changes
Copy link
Member

@tjvr tjvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough—let's merge it! Thanks!

@apple502j apple502j merged commit 69354ff into scratchblocks:master Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjvr tjvr tjvr approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

exportPNG crashes when input is empty string
2 participants
@apple502j @tjvr