Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parameteres to most Deferred instances. #6414

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

wRAR
Copy link
Member

@wRAR wRAR commented Jun 25, 2024

No description provided.

Copy link

codecov bot commented Jun 25, 2024

Codecov Report

Attention: Patch coverage is 85.10638% with 14 lines in your changes missing coverage. Please review.

Project coverage is 84.64%. Comparing base (feb0b8f) to head (7f012b0).
Report is 42 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #6414       +/-   ##
===========================================
+ Coverage   43.98%   84.64%   +40.65%     
===========================================
  Files         162      162               
  Lines       12183    12049      -134     
  Branches     1730     1854      +124     
===========================================
+ Hits         5359    10199     +4840     
+ Misses       6447     1552     -4895     
+ Partials      377      298       -79     
Files Coverage Δ
scrapy/core/downloader/handlers/http10.py 100.00% <100.00%> (+48.27%) ⬆️
scrapy/core/scraper.py 86.38% <100.00%> (+23.62%) ⬆️
scrapy/core/spidermw.py 99.45% <ø> (+51.12%) ⬆️
scrapy/crawler.py 89.17% <100.00%> (+37.43%) ⬆️
scrapy/downloadermiddlewares/robotstxt.py 100.00% <100.00%> (+70.21%) ⬆️
scrapy/dupefilters.py 98.38% <100.00%> (+40.81%) ⬆️
scrapy/extensions/feedexport.py 83.37% <100.00%> (+14.42%) ⬆️
scrapy/middleware.py 98.24% <100.00%> (+6.86%) ⬆️
scrapy/shell.py 67.37% <100.00%> (+67.37%) ⬆️
scrapy/signalmanager.py 90.90% <100.00%> (+9.09%) ⬆️
... and 11 more

... and 123 files with indirect coverage changes

@Gallaecio Gallaecio merged commit e47110f into scrapy:master Jun 26, 2024
27 checks passed
@wRAR wRAR deleted the typing-deferred-scrapy branch July 3, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants