Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: Discord Integrations should be optional #4113

Closed
z64555 opened this issue Mar 28, 2022 · 2 comments · Fixed by #6482
Closed

FR: Discord Integrations should be optional #4113

z64555 opened this issue Mar 28, 2022 · 2 comments · Fixed by #6482
Labels
build An issue related to the build systems enhancement A new feature or upgrade of an existing feature to add additional functionality. good first issue An issue thats "easy" to do and is recommended for beginning contributors library A feature or issue related to third-party libraries

Comments

@z64555
Copy link
Member

z64555 commented Mar 28, 2022

A discussion brought up by freijon on Discord prompted the case of making our Discord Rich Presence support into something optional.

I'm thinking at the least a commandline option should be added to opt-out (or opt-in) to using Discord RP, and a Cmake option should be added to allow the Discord RP libs to be excluded.

@z64555 z64555 added build An issue related to the build systems library A feature or issue related to third-party libraries good first issue An issue thats "easy" to do and is recommended for beginning contributors labels Mar 28, 2022
@MjnMixael
Copy link
Contributor

If this is about library inclusion and building, that's generally pretty specific to Linux users I think. Setup the feature to work if the library is present and not to break if it isn't. Then let Linux users decide at build time.

If this is just about the feature at all for general users, it should be implemented into the new Options menu or a game_settings.tbl flag while taking a deeper look into the idea in #3934 for user settings. I'm generally against adding more commandline flags, though admittedly this one actually seems to fit there slightly more than a lot of the junk we currently have... That's my 2c not that my opinion matters much on the issue.

If going commandline, many of the graphics flags are opt-out rather than opt-in. Maybe follow the same trend.

@freijon
Copy link
Contributor

freijon commented Mar 28, 2022

Maybe a short background explaination:
Most Linux distros are 'binary', meaning the packages they install are pre-compiled and the package maintainer decides which features to include. Same for the AppImage. Then there are 'source' based distros (they are a minority) where the end-user decides which features to include. They are presented with a list of features to include/exclude at build time. If we disable discord-rpc it means don't build the discord library and remove all calls to that library.
For the 'binary' distros or Mac OS / Windows which have the feature compiled in by default, it would certainly be nice to have a cmd line option to opt-out sharing this info online.

@JohnAFernandez JohnAFernandez added the enhancement A new feature or upgrade of an existing feature to add additional functionality. label Jul 13, 2022
Repository owner moved this from Todo to Done in Issue Management Oct 3, 2022
@Goober5000 Goober5000 reopened this Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build An issue related to the build systems enhancement A new feature or upgrade of an existing feature to add additional functionality. good first issue An issue thats "easy" to do and is recommended for beginning contributors library A feature or issue related to third-party libraries
Projects
Status: Medium Impact
Development

Successfully merging a pull request may close this issue.

5 participants