Logging autoinstrument layers that are significant/insignicant + ignoring files #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instrumenting many insignificant layers adds overhead. These insignificant layers are unlikely to be areas a developer will optimize. This adds a persistant Histogram that logs a count of total autoinstrumented layers and the percent significant per-file name.
```
[09/19/19 10:55:36 -0600 Dereks-MacBook-Pro.local (66345)] DEBUG : AutoInstrument Layer Histograms: {"/Users/dlite/projects/scout/apm/app/controllers/application_controller.rb"=>
{:total=>1774, :significant=>0.08},
"/Users/dlite/projects/scout/apm/app/controllers/status_pages_controller.rb"=>
{:total=>5, :significant=>0.2},
"/Users/dlite/projects/scout/apm/app/controllers/checkin_controller.rb"=>
{:total=>52, :significant=>0.23},
"/Users/dlite/projects/scout/apm/app/controllers/deploys_controller.rb"=>
{:total=>15, :significant=>0.2},
"/Users/dlite/projects/scout/apm/app/controllers/apps_controller.rb"=>
{:total=>57, :significant=>0.46},
"/Users/dlite/projects/scout/apm/app/controllers/errors_controller.rb"=>
{:total=>4, :significant=>1.0},
"/Users/dlite/projects/scout/apm/app/controllers/insights_controller.rb"=>
{:total=>4, :significant=>1.0},
"/Users/dlite/projects/scout/apm/app/controllers/alerts_controller.rb"=>
{:total=>8, :significant=>0.25},
"/Users/dlite/projects/scout/apm/app/controllers/traces_controller.rb"=>
{:total=>12, :significant=>0.42},
"/Users/dlite/projects/scout/apm/app/controllers/endpoints_controller.rb"=>
{:total=>22, :significant=>0.32}}
```
cschneid
reviewed
Sep 19, 2019
This adds a `auto_instruments_ignore` config option so files can be excluded from autoinstruments. By defaut this is an empty array. Example usage: `auto_instruments_ignore: ['application_controller']`.
itsderek23
changed the title
itsderek23
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instrumenting many insignificant layers adds overhead. These insignificant layers are unlikely to be areas a developer will optimize. This adds a persistant Histogram that logs a count of total autoinstrumented layers and the percent significant per-file name.
In the example output below,
application_controller.rbis potentially adding overhead as it is tracking a large number of layers and a low percentage (8%) are significant. This file can be excluded from autoinstruments via the newautoinstrumentsconfig option:auto_instruments_ignore: ['application_controller'].