Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: scoutapp/scout_apm_ruby
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v2.6.0
Choose a base ref
...
head repository: scoutapp/scout_apm_ruby
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v2.6.1
Choose a head ref
  • 8 commits
  • 15 files changed
  • 2 contributors

Commits on Sep 19, 2019

  1. WIP logging autoinstrument layers that are significant/insignicant

    Instrumenting many insignificant layers adds overhead. These insignificant layers are unlikely to be areas a developer will optimize. This adds a persistant Histogram that logs a count of total autoinstrumented layers and the percent significant per-file name.
    
    ```
    [09/19/19 10:55:36 -0600 Dereks-MacBook-Pro.local (66345)] DEBUG : AutoInstrument Layer Histograms: {"/Users/dlite/projects/scout/apm/app/controllers/application_controller.rb"=>
      {:total=>1774, :significant=>0.08},
     "/Users/dlite/projects/scout/apm/app/controllers/status_pages_controller.rb"=>
      {:total=>5, :significant=>0.2},
     "/Users/dlite/projects/scout/apm/app/controllers/checkin_controller.rb"=>
      {:total=>52, :significant=>0.23},
     "/Users/dlite/projects/scout/apm/app/controllers/deploys_controller.rb"=>
      {:total=>15, :significant=>0.2},
     "/Users/dlite/projects/scout/apm/app/controllers/apps_controller.rb"=>
      {:total=>57, :significant=>0.46},
     "/Users/dlite/projects/scout/apm/app/controllers/errors_controller.rb"=>
      {:total=>4, :significant=>1.0},
     "/Users/dlite/projects/scout/apm/app/controllers/insights_controller.rb"=>
      {:total=>4, :significant=>1.0},
     "/Users/dlite/projects/scout/apm/app/controllers/alerts_controller.rb"=>
      {:total=>8, :significant=>0.25},
     "/Users/dlite/projects/scout/apm/app/controllers/traces_controller.rb"=>
      {:total=>12, :significant=>0.42},
     "/Users/dlite/projects/scout/apm/app/controllers/endpoints_controller.rb"=>
      {:total=>22, :significant=>0.32}}
    ```
    itsderek23 committed Sep 19, 2019
    Configuration menu
    Copy the full SHA
    7da3f13 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2019

  1. Cleanup and comments

    itsderek23 committed Sep 23, 2019
    Configuration menu
    Copy the full SHA
    84575a5 View commit details
    Browse the repository at this point in the history
  2. Adding auto_instruments_ignore config option

    This adds a `auto_instruments_ignore` config option so files can be excluded from autoinstruments. By defaut this is an empty array. Example usage: `auto_instruments_ignore: ['application_controller']`.
    itsderek23 committed Sep 23, 2019
    Configuration menu
    Copy the full SHA
    551f561 View commit details
    Browse the repository at this point in the history
  3. Fixing broken tests

    itsderek23 committed Sep 23, 2019
    4 Configuration menu
    Copy the full SHA
    847d72e View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    1189020 View commit details
    Browse the repository at this point in the history
  5. Hash Rocket syntax

    itsderek23 committed Sep 23, 2019
    Configuration menu
    Copy the full SHA
    da62aca View commit details
    Browse the repository at this point in the history
  6. Merge pull request #283 from scoutapp/auto_instruments_logging

    Logging autoinstrument layers that are significant/insignicant + ignoring files
    itsderek23 authored Sep 23, 2019
    Configuration menu
    Copy the full SHA
    e05dcde View commit details
    Browse the repository at this point in the history
  7. Version bump

    itsderek23 committed Sep 23, 2019
    Configuration menu
    Copy the full SHA
    9be913f View commit details
    Browse the repository at this point in the history
Loading