Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add example templates for ppc64le imagestreams #204

Merged
merged 1 commit into from
Sep 25, 2018
Merged

add example templates for ppc64le imagestreams #204

merged 1 commit into from
Sep 25, 2018

Conversation

jeffdyoung
Copy link

add example templates for ppc64le imagestreams

@bparees
Copy link

bparees commented Sep 17, 2018

what's the delta between these and the existing templates?

@jeffdyoung
Copy link
Author

In this case, the diff between x86/ppc64le isn't very much:

#diff nodejs.json nodejs-ppc64le.json
9c9
< "tags": "quickstart,nodejs",
---
> "tags": "quickstart,nodejs,ppc64le",

#diff nodejs-mongodb.json nodejs-mongodb-ppc64le.json
445,446c445,446
< "description": "Version of MongoDB image to be used (3.2, 3.4, or latest).",
< "value": "3.4",
---
> "description": "Version of MongoDB image to be used (3.6 or latest).",
> "value": "3.6",

#diff nodejs-mongodb-persistent.json nodejs-mongodb-persistent-ppc64le.json
9c9
< "tags": "quickstart,nodejs",
---
> "tags": "quickstart,nodejs,ppc64le",
461,462c461,462
< "description": "Version of MongoDB image to be used (3.2, 3.4, or latest).",
< "value": "3.4",
---
> "description": "Version of MongoDB image to be used (3.6 or latest).",
> "value": "3.6",

@hhorak
Copy link
Member

hhorak commented Sep 25, 2018

LGTM, thanks.

@hhorak hhorak merged commit 905416d into sclorg:master Sep 25, 2018
@jeffdyoung jeffdyoung deleted the ppc64le branch September 25, 2018 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants