-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move openshift templates off of EOL mysql 5.7 #113
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!!!. Version is now properly set.
heads up @phracek please see my latest emails about these templates failing in openshift testing when using |
@gabemontero is correct, with mysql:8.0 the default auth method changed and while we changed it for RPMs, the container is not doing the same. I think changing the default auth mechanism is not a good idea, given the container is used by end users for some time, so my current thinking is to do this:
Does it make sense? |
I believe so @hhorak Sounds like changes to https://github.com/sclorg/mysql-container first, and then changes to this repo, correct? |
FYI I've opened https://bugzilla.redhat.com/show_bug.cgi?id=1793116 to track the work noted above, as I'm starting to get external queries on this and it would be better for us to have a bugzilla on the books in case customer try the cakephp/mysql template with mysql:8 on its own. Looks like the jira https://projects.engineering.redhat.com/browse/RHELPLAN-33096 got auto-generated as a result |
@hhorak @phracek @pkubatrh - any updates if we can unblock this PR ? I had to again refrain from updating the mysql imagestream as part of openshift 4.5 because the cakephp mysql templates still reference 5.7 I could update mysql/cakephp via bugzilla over the next week or two if we get this merged. thanks |
AFAICS sclorg/mysql-container#280 has been shipped in rhscl/mysql-80-rhel7 since 8.0-30 (RHSCL 3.4) and rhel8/mysql-80 since 1-86 (RHEL 8.2). |
/retitle move openshift templates off of EOL mysql 5.7 |
@hhorak what else is needed to unblock this? |
I think it can be unblocked. I will ping @hhorak |
Very sorry for delaying this, yes, it can be unblocked. Actually can be merged now, so doing it. |
So we ran some tests as part of some OKD work for openshift samples using the new version of these OCP templates that used mysql 8.0 vs. 5.7 and it looks like still hit the issues originally reported by https://bugzilla.redhat.com/show_bug.cgi?id=1793116 @yselkowitz @hhorak We've reverted the change in openshfit samples operator for now to get the OKD work through, and I'll create a separate test PR with just that change and then post the test results for examination. In case it matters, is a change to the mysql imagestream to get the correct version of the mysql 8.x image needed. Currently the images stream references |
What about #114 ? |
Certainly seems relevant. I was previously unaware of it. Thanks @yselkowitz |
@phracek @pkubatrh @hhorak PTAL
in the interim I'm patching the openshift 4.x samples operator to avoid issues with the recent imagestream EOL removals