Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move openshift templates off of EOL mysql 5.7 #113

Merged
merged 1 commit into from
Jul 16, 2020

Conversation

gabemontero
Copy link
Contributor

@phracek @pkubatrh @hhorak PTAL

in the interim I'm patching the openshift 4.x samples operator to avoid issues with the recent imagestream EOL removals

Copy link
Member

@phracek phracek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!!!. Version is now properly set.

@gabemontero
Copy link
Contributor Author

heads up @phracek please see my latest emails about these templates failing in openshift testing when using mysql:8

@hhorak hhorak changed the title move openshift templates off of EOL mysql 5.7 [DO NOT MERGE] move openshift templates off of EOL mysql 5.7 Jan 17, 2020
@hhorak
Copy link
Member

hhorak commented Jan 17, 2020

@gabemontero is correct, with mysql:8.0 the default auth method changed and while we changed it for RPMs, the container is not doing the same. I think changing the default auth mechanism is not a good idea, given the container is used by end users for some time, so my current thinking is to do this:

  • Add a new variable to specify auth mechanism for mysql:8.0 container
  • Use this variable and specify older mechanism in the cakephp template

Does it make sense?

@gabemontero
Copy link
Contributor Author

@gabemontero is correct, with mysql:8.0 the default auth method changed and while we changed it for RPMs, the container is not doing the same. I think changing the default auth mechanism is not a good idea, given the container is used by end users for some time, so my current thinking is to do this:

* Add a new variable to specify auth mechanism for mysql:8.0 container

* Use this variable and specify older mechanism in the cakephp template

Does it make sense?

I believe so @hhorak

Sounds like changes to https://github.com/sclorg/mysql-container first, and then changes to this repo, correct?

@gabemontero
Copy link
Contributor Author

FYI I've opened https://bugzilla.redhat.com/show_bug.cgi?id=1793116 to track the work noted above, as I'm starting to get external queries on this and it would be better for us to have a bugzilla on the books in case customer try the cakephp/mysql template with mysql:8 on its own.

Looks like the jira https://projects.engineering.redhat.com/browse/RHELPLAN-33096 got auto-generated as a result

@gabemontero
Copy link
Contributor Author

ok with the updates to the mysql image that you all recenty merged @hhorak @phracek I'll defer to you on when we can unblock this PR so that the template uses mysql:8 vs. mysql:5.7

@gabemontero
Copy link
Contributor Author

@hhorak @phracek @pkubatrh - any updates if we can unblock this PR ?

I had to again refrain from updating the mysql imagestream as part of openshift 4.5 because the cakephp mysql templates still reference 5.7

I could update mysql/cakephp via bugzilla over the next week or two if we get this merged.

thanks

@gabemontero
Copy link
Contributor Author

@hhorak @phracek @pkubatrh ... my periodic ask if we can unblock this PR ... has the mysql:8 image been updated to address the bz's / jira's noted above

@coreydaley @adambkaplan @yselkowitz @jaypoulz FYI

@yselkowitz
Copy link
Contributor

AFAICS sclorg/mysql-container#280 has been shipped in rhscl/mysql-80-rhel7 since 8.0-30 (RHSCL 3.4) and rhel8/mysql-80 since 1-86 (RHEL 8.2).

@yselkowitz
Copy link
Contributor

/retitle move openshift templates off of EOL mysql 5.7

@yselkowitz
Copy link
Contributor

@hhorak what else is needed to unblock this?

@phracek
Copy link
Member

phracek commented Jul 16, 2020

I think it can be unblocked. I will ping @hhorak

@hhorak hhorak changed the title [DO NOT MERGE] move openshift templates off of EOL mysql 5.7 move openshift templates off of EOL mysql 5.7 Jul 16, 2020
@hhorak
Copy link
Member

hhorak commented Jul 16, 2020

Very sorry for delaying this, yes, it can be unblocked. Actually can be merged now, so doing it.

@hhorak hhorak merged commit 11e032d into sclorg:master Jul 16, 2020
@gabemontero
Copy link
Contributor Author

So we ran some tests as part of some OKD work for openshift samples using the new version of these OCP templates that used mysql 8.0 vs. 5.7 and it looks like still hit the issues originally reported by https://bugzilla.redhat.com/show_bug.cgi?id=1793116 @yselkowitz @hhorak

We've reverted the change in openshfit samples operator for now to get the OKD work through, and I'll create a separate test PR with just that change and then post the test results for examination.

In case it matters, is a change to the mysql imagestream to get the correct version of the mysql 8.x image needed. Currently the images stream references registry.redhat.io/rhscl/mysql-80-rhel7:latest ?

@yselkowitz
Copy link
Contributor

What about #114 ?

@gabemontero
Copy link
Contributor Author

What about #114 ?

Certainly seems relevant. I was previously unaware of it. Thanks @yselkowitz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants