DOC: Fixed typo in signal.ellipap #20675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As it says on the tin -- added the missing letter to prof. Lutovac's last name in the docstring of signal.ellipap, as mentioned in issue scipy#20674
github-actions
bot
added
scipy.signal
Documentation
j-bowhay
approved these changes
May 9, 2024
There was a problem hiding this comment.
Thanks @budjen-jovan, looking at https://github.com/scipy/scipy/blob/main/tools/unicode-check.py I am not sure we support the unicode characters you are suggesting for the further enhancement
|
I was kind of expecting it, it's fine either way, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[docs only]
Reference issue
Potentially closes #20674, depending if non-ascii characters are allowed. It's acceptable regardless of the other issue mentioned
What does this implement/fix?
Added a missing letter to prof. Lutovac's last name in references of signal.ellipap
Additional information
I'm not sure if I'm supposed to add the docs only string here, please do let me know if I messed up