Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAINT: remove unused variable in special #20657

Merged
merged 1 commit into from
May 7, 2024
Merged

MAINT: remove unused variable in special #20657

merged 1 commit into from
May 7, 2024

Conversation

andyfaff
Copy link
Contributor

@andyfaff andyfaff commented May 7, 2024

Whilst building on macOS I see several warnings of the type:

../scipy/special/special/hyp2f1.h:639:31: note: in instantiation of function template specialization 'special::detail::series_eval<special::detail::LopezTemmeSeriesGenerator, std::complex<double>>' requested here
            result *= detail::series_eval(series_generator, std::complex<double>{0.0, 0.0}, detail::hyp2f1_EPS,
                              ^
In file included from ../scipy/special/_special_ufuncs.cpp:16:
In file included from ../scipy/special/special/hyp2f1.h:44:
../scipy/special/special/tools.h:44:17: warning: unused variable 'previous' [-Wunused-variable]
        T term, previous;
                ^

This PR removes the unused variable.

@andyfaff andyfaff requested review from person142 and steppi as code owners May 7, 2024 03:52
@github-actions github-actions bot added scipy.special C/C++ Items related to the internal C/C++ code base maintenance Items related to regular maintenance tasks labels May 7, 2024
lucascolley
lucascolley approved these changes May 7, 2024
View reviewed changes
Copy link
Member

@lucascolley lucascolley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks Andrew!

@lucascolley lucascolley merged commit a4ccee2 into scipy:main May 7, 2024
31 checks passed
@lucascolley lucascolley added this to the 1.14.0 milestone May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucascolley lucascolley lucascolley approved these changes

@person142 person142 Awaiting requested review from person142 person142 is a code owner

@steppi steppi Awaiting requested review from steppi steppi is a code owner

Assignees
No one assigned
Labels
C/C++ Items related to the internal C/C++ code base maintenance Items related to regular maintenance tasks scipy.special
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.
2 participants
@andyfaff @lucascolley